Attention is currently required from: osmith.

View Change

1 comment:

• File src/osmo-bts-sysmo/l1_if.c:

  • Patch Set #3, Line 1264: if (!trx->mo.opstart_success)

    IMHO you should move this trx_rf_lock up to line 1258, and you could even simply remove bts_update_status since you are locking now immediatelly.
    Moreover, this "if (!trx->mo.opstart_success)" doesn't make sense to me, since for sure OPSTART is to be done far afterwards, you can simply drop the check.

To view, visit change 33457. To unsubscribe, or for help writing mail filters, visit settings.