Attention is currently required from: laforge.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32036 )
Change subject: map_sccp: on timeout during WAIT_CC, send N-DISCONNECT to SCCP-SCOC
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Patchset:
PS2:
I'm actually wondering why we have such a state to
begin with? Isn't it the job of the SCCP provide […]
yes, after the FSMs were
merged, it has already occurred to me that the new code could/should have relied more on
sccp_scoc.c timeouts that are already in place, instead of "duplicating" SCCP
states. Now the code is there and works correctly... maybe i can take another look some
time.
PS2:
combine votes
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32036
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ie94fcee4e2507a55449050aab96307199aed99a2
Gerrit-Change-Number: 32036
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 28 Mar 2023 02:04:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment