Attention is currently required from: laforge.
Patch set 2:Code-Review +2
View Change
2 comments:
Patchset:
Patch Set #2:
I'm actually wondering why we have such a state to begin with? Isn't it the job of the SCCP provide […]
yes, after the FSMs were merged, it has already occurred to me that the new code could/should have relied more on sccp_scoc.c timeouts that are already in place, instead of "duplicating" SCCP states. Now the code is there and works correctly... maybe i can take another look some time.
Patch Set #2:
combine votes
To view, visit change 32036. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ie94fcee4e2507a55449050aab96307199aed99a2
Gerrit-Change-Number: 32036
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Comment-Date: Tue, 28 Mar 2023 02:04:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Gerrit-MessageType: comment