Attention is currently required from: csaba.sipos, fixeria.
pespin has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email )
Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File src/osmo-bsc/bts_nokia_site.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/68f482e4_4ec607aa?usp=... : PS5, Line 1823: if (find_element(noh->data, len_data, NOKIA_EI_OBJ_ID_STATE, object_id_state, sizeof(object_id_state))) { can we pelase use early return to simplify code:
if (!find_element(...) { LOG_BTS("missing..."); return -EINVAL; } LOG_BTS("State changed");