Attention is currently required from: csaba.sipos, fixeria.

Patch set 5:Code-Review +1

View Change

1 comment:

• File src/osmo-bsc/bts_nokia_site.c:

  • Patch Set #5, Line 1823: if (find_element(noh->data, len_data, NOKIA_EI_OBJ_ID_STATE, object_id_state, sizeof(object_id_state))) {

    can we pelase use early return to simplify code:

        if (!find_element(...) {
          LOG_BTS("missing...");
          return -EINVAL;
        }
        LOG_BTS("State changed");

To view, visit change 39416. To unsubscribe, or for help writing mail filters, visit settings.