Attention is currently required from: neels.
laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39741?usp=email )
Change subject: [1/6] personalization: refactor: drop ClassVarMeta use ......................................................................
Patch Set 9: Code-Review-1
(2 comments)
Patchset:
PS9: I retain my position that I don't understand why this change is made in the first place, and where it improves upon the existing code. "Not using metaclasses" is not something I understand as an improvement, and clearly the readability has also not improved.
I'm also a bit dissatisfied by the fact that this is the first change you introduce as part of your work on this task. It's not a functional change or anything that adds a feature, but it's a change that is mostly cosmetic and alters the existing code to be more to your personal preference without rendering a [AFAICT, and apparently fixeria agrees] clear advantage.
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/39741/comment/6f7d2351_753b426c?usp=ema... : PS9, Line 37: class ConfigurableParameter: why is the new ConfugirableParameter not an ABC anymore? Can it be used directly, without further inheriting from it?