Attention is currently required from: laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33087 )
Change subject: libosmogsm: Support authentication with 256-bit K and/or OP/OPc ......................................................................
Patch Set 4: Code-Review+1
(3 comments)
File include/osmocom/crypt/auth.h:
https://gerrit.osmocom.org/c/libosmocore/+/33087/comment/d48dcdf1_383a45e8 PS4, Line 66: /* deprecated older structure without support for 32-byte K/OP[c] */ BTW, you can attach `OSMO_DEPRECATED` to structures too. Even more: you can deprecate specific fields of structs, but gcc seems to ignore these per-field struct attributes (clang does print warnings as expected).
File src/gsm/auth_core.c:
https://gerrit.osmocom.org/c/libosmocore/+/33087/comment/5e0fc64d_3356f9c5 PS4, Line 219: auth_data2auth_data2 check return value?
https://gerrit.osmocom.org/c/libosmocore/+/33087/comment/c1d30d5d_28fdeb56 PS4, Line 285: auth_data2auth_data2 check return value?