Attention is currently required from: laforge.

Patch set 4:Code-Review +1

View Change

3 comments:

• File include/osmocom/crypt/auth.h:

  • Patch Set #4, Line 66: /* deprecated older structure without support for 32-byte K/OP[c] */

    BTW, you can attach `OSMO_DEPRECATED` to structures too. Even more: you can deprecate specific fields of structs, but gcc seems to ignore these per-field struct attributes (clang does print warnings as expected).

• File src/gsm/auth_core.c:

  • Patch Set #4, Line 219: auth_data2auth_data2

    check return value?

  • Patch Set #4, Line 285: auth_data2auth_data2

    check return value?

To view, visit change 33087. To unsubscribe, or for help writing mail filters, visit settings.