[M] Change in libosmocore[master]: gsmtap: Hide implementation of gsmtap_inst

Attention is currently required from: daniel, laforge, pespin. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email ) Change subject: gsmtap: Hide implementation of gsmtap_inst ...................................................................... Patch Set 3: Code-Review-1 (3 comments) File TODO-RELEASE: https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/191b6602_76b8b7be PS3, Line 11: core ADD gsmtap_inst_fd2() append: (Deprecate gsmtap_inst_fd()) File include/osmocom/core/gsmtap_util.h: https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/6c7449f5_c9f7f6e6 PS3, Line 32: int gsmtap_inst_fd2(struct gsmtap_inst *gti); while at it, make gti const :) File src/core/logging_gsmtap.c: https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/14ca953a_3e11f19f PS3, Line 54: struct gsmtap_inst; This is not needed, you are already adding gsmtap_util.h abovewhich adds this line. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e365825555609a5 Gerrit-Change-Number: 34720 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Oct 2023 14:48:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment