Attention is currently required from: msuraev.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31091 )
Change subject: SI13: drop meaningless error check
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bsc/+/31091/comment/b498d6f4_ed72dd5c
PS1, Line 9: always return positive integer
But it still returns a signed integer, and some day somebody may add an additional checks
making it return a negative number. So it's not really a meaningless check.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31091
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib1aeaa57ad0929fd2e1296737969d89485f0ac7b
Gerrit-Change-Number: 31091
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 04 Feb 2023 18:20:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment