Attention is currently required from: msuraev.
Patch set 1:Code-Review -1
View Change
1 comment:
Commit Message:
Patch Set #1, Line 9: always return positive integer
But it still returns a signed integer, and some day somebody may add an additional checks making it return a negative number. So it's not really a meaningless check.
To view, visit change 31091. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib1aeaa57ad0929fd2e1296737969d89485f0ac7b
Gerrit-Change-Number: 31091
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: msuraev <msuraev@sysmocom.de>
Gerrit-Comment-Date: Sat, 04 Feb 2023 18:20:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment