Attention is currently required from: neels, laforge, fixeria, Max. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 )
Change subject: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD ......................................................................
Patch Set 16:
(4 comments)
File src/sccp_scoc.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/a81464a3_aa110981 PS15, Line 600: if (
We shouldn't. […]
Simply drop it then.
https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/d28a52f7_7f4401a2 PS15, Line 606: } else
Actually it's better to add them to else according to https://www.kernel. […]
"Do not unnecessarily use braces where a single statement will do." So why do you say it's better according to it?
https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/cd5f094b_282695b0 PS15, Line 635: LOGP(DLSCCP, LOGL_ERROR, "replacing unsent %u bytes of optional data cache with %s optional data\n",
I think it's error - this situation should not arise normally.
AFAIU that's something coming from outside, from a peer, so not really an error of the program itself. Not important though.
https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/68333f0c_d0c3678f PS15, Line 784: xua_msg_add_sccp_addr(xua, SUA_IEI_DEST_ADDR, &conn->calling_addr);
Similar to the above: the comments are placed to match the fields order in the spec.
Then write a new comit "comments are placed to match the fields order in the spec."