Attention is currently required from: neels, laforge, fixeria, Max.
4 comments:
File src/sccp_scoc.c:
We shouldn't. […]
Simply drop it then.
Patch Set #15, Line 606: } else
Actually it's better to add them to else according to https://www.kernel. […]
"Do not unnecessarily use braces where a single statement will do." So why do you say it's better according to it?
Patch Set #15, Line 635: LOGP(DLSCCP, LOGL_ERROR, "replacing unsent %u bytes of optional data cache with %s optional data\n",
I think it's error - this situation should not arise normally.
AFAIU that's something coming from outside, from a peer, so not really an error of the program itself.
Not important though.
Patch Set #15, Line 784: xua_msg_add_sccp_addr(xua, SUA_IEI_DEST_ADDR, &conn->calling_addr);
Similar to the above: the comments are placed to match the fields order in the spec.
Then write a new comit "comments are placed to match the fields order in the spec."
To view, visit change 29084. To unsubscribe, or for help writing mail filters, visit settings.