Attention is currently required from: pespin, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31080 )
Change subject: SI: add missing header ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/31080/comment/755f2d7a_9aaf1ed9 PS1, Line 12: Change-Id: Ia7530e9c8a21f6f99f3aac7baea5cbb38763c4f3 Fixes: 600d4eeab71665c0aec0a11a226d231f109534ca
File include/osmocom/gsm/gsm48.h:
https://gerrit.osmocom.org/c/libosmocore/+/31080/comment/35863964_4e970e33 PS1, Line 38: const char *gsm48_rr_msg_type_short_name(uint8_t msgtype);
I wonder why isn't this named gsm48_rr_msg_short_name() following the existing ones.
Ack, I also find the current naming confusing. It may look like the function is returning a short name. I suggest to rename it, before it's too late. How about: gsm48_rr_short_pd_msg_name()?