Attention is currently required from: pespin, msuraev.

View Change

2 comments:

• Commit Message:

  • Patch Set #1, Line 12: Change-Id: Ia7530e9c8a21f6f99f3aac7baea5cbb38763c4f3

    Fixes: 600d4eeab71665c0aec0a11a226d231f109534ca

• File include/osmocom/gsm/gsm48.h:

  • Patch Set #1, Line 38: const char *gsm48_rr_msg_type_short_name(uint8_t msgtype);

    I wonder why isn't this named gsm48_rr_msg_short_name() following the existing ones.

    Ack, I also find the current naming confusing. It may look like the function is returning a short name. I suggest to rename it, before it's too late. How about: gsm48_rr_short_pd_msg_name()?

To view, visit change 31080. To unsubscribe, or for help writing mail filters, visit settings.