Change in osmo-bsc[master]: pcu_sock: transfer E1 connection information to PCU

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31144 ) Change subject: pcu_sock: transfer E1 connection information to PCU ...................................................................... Patch Set 3: (3 comments) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/cedf9095_e9b61231 PS1, Line 315: struct gsm_bts_trx_ts *ts; This is actually a good practice. By having if/for/while scoped variables, you're telling the compiler more about their lifetime, so it may potentially apply some additional optimizations. There is of course a tradeoff between having everything scoped and readability of the code. I recommend reading this thread: https://stackoverflow.com/questions/8474100/where-you-can-and-cannot-declar…. Not critical though, you can leave it as it is. File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/0777971f_311d0d73 PS3, Line 318: if (!trx) this condition can never be true https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/d82e4c57_46600410 PS3, Line 346: LOGP Let's use LOG_TRX here. This will shorten the logging message to: "Sending E1 CCU info for TS%u\n" -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6d44373336b41009ff4c6e459d32d0a81081676c Gerrit-Change-Number: 31144 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 03 Feb 2023 20:34:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment