Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31144 )
Change subject: pcu_sock: transfer E1 connection information to PCU ......................................................................
Patch Set 3:
(3 comments)
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/cedf9095_e9b61231 PS1, Line 315: struct gsm_bts_trx_ts *ts;
I don't think that it is a good idea to declare the variables in other places as at the top of a fun […]
This is actually a good practice. By having if/for/while scoped variables, you're telling the compiler more about their lifetime, so it may potentially apply some additional optimizations. There is of course a tradeoff between having everything scoped and readability of the code. I recommend reading this thread: https://stackoverflow.com/questions/8474100/where-you-can-and-cannot-declare.... Not critical though, you can leave it as it is.
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/0777971f_311d0d73 PS3, Line 318: if (!trx) this condition can never be true
https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/d82e4c57_46600410 PS3, Line 346: LOGP Let's use LOG_TRX here. This will shorten the logging message to:
"Sending E1 CCU info for TS%u\n"