Attention is currently required from: dexter.

3 comments:

File src/osmo-bsc/pcu_sock.c:
- Patch Set #1, Line 315: struct gsm_bts_trx_ts *ts;
  I don't think that it is a good idea to declare the variables in other places as at the top of a fun […]
  This is actually a good practice. By having if/for/while scoped variables, you're telling the compiler more about their lifetime, so it may potentially apply some additional optimizations. There is of course a tradeoff between having everything scoped and readability of the code. I recommend reading this thread: https://stackoverflow.com/questions/8474100/where-you-can-and-cannot-declare-new-variables-in-c. Not critical though, you can leave it as it is.
File src/osmo-bsc/pcu_sock.c:
- Patch Set #3, Line 318: if (!trx)
  this condition can never be true
- Patch Set #3, Line 346: LOGP
  Let's use LOG_TRX here. This will shorten the logging message to:
```
  "Sending E1 CCU info for TS%u\n"
```

To view, visit change 31144. To unsubscribe, or for help writing mail filters, visit settings.