Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31025 )
Change subject: Introduce tundev API ......................................................................
Patch Set 11: Code-Review+1
(5 comments)
File src/core/tun.c:
https://gerrit.osmocom.org/c/libosmocore/+/31025/comment/6868aad5_71b810d0 PS4, Line 73: *NULL
missing space
Done
https://gerrit.osmocom.org/c/libosmocore/+/31025/comment/cef38624_43cfbaa7 PS4, Line 87: bu
by?
Done
File src/core/tun.c:
https://gerrit.osmocom.org/c/libosmocore/+/31025/comment/61223f72_f6c88113 PS9, Line 184: NULL
I don't plan to pass this from the API, since the ctx passed there is per tundev and may be expected […]
Ack
https://gerrit.osmocom.org/c/libosmocore/+/31025/comment/115eab24_a0ad07f6 PS9, Line 371: |=
Yes this is expected, as per https://git.netfilter.org/libmnl/tree/examples/rtnl/rtnl-link-set. […]
Ack
File src/core/tun.c:
https://gerrit.osmocom.org/c/libosmocore/+/31025/comment/c9659243_fada0f59 PS11, Line 834: (tundev)->netns_name); \ the line below LOGTUN with additional arguments needs more indentation, same 3x below