Change in osmo-e1-hardware[master]: fw/e1-tracer: e1_start/e1_stop of individual channel

Attention is currently required from: laforge. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29947 ) Change subject: fw/e1-tracer: e1_start/e1_stop of individual channel ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File firmware/ice40-riscv/e1-tracer/e1.c: https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29947/comment/242f894f_2584… PS1, Line 280: e1_start_one(uint8_t chan) I wouldn't rename it. In icE1usb we have e1_start(int port) and ultimately I'd like e1.{c,h} to be shared between the two. (usb_e1 will most likely stay separate because there'll be too much difference there, but the driver for the E1 hw shouln't be all that different ultimately) -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29947 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I7492325352222269bf0ba1346511c7dfa99c4f64 Gerrit-Change-Number: 29947 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 01 Nov 2022 19:22:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment