Attention is currently required from: laforge.

Patch set 1:Code-Review +1

View Change

1 comment:

• File firmware/ice40-riscv/e1-tracer/e1.c:

  • Patch Set #1, Line 280: e1_start_one(uint8_t chan)

    I wouldn't rename it.

    In icE1usb we have e1_start(int port) and ultimately I'd like e1.{c,h} to be shared between the two.

    (usb_e1 will most likely stay separate because there'll be too much difference there, but the driver for the E1 hw shouln't be all that different ultimately)

To view, visit change 29947. To unsubscribe, or for help writing mail filters, visit settings.