Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31098 )
Change subject: rlcmac: Enqueue LLC PDUs based on RadioPriority and SAPI ......................................................................
Patch Set 3:
(2 comments)
File src/rlcmac/gre.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31098/comment/8ce5f9b8_b58fa759 PS3, Line 72: /* TODO: here a new UL TBF will be created if not available yet */
Yes, I'm adding code modules in a step-by-step way, so that it's not a final code bomb with 30 files […]
Makes sense to do it that way. Sometimes a TODO is kept unintentionally though, so that's why I keep asking about them.
File src/rlcmac/llc_queue.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31098/comment/34b92ffd_7332e537 PS3, Line 196: /* rate_ctr_inc(CTR_LLC_FRAME_DROPPED); */
I left it there on purpose so that a potential counter can be identified quickly and added there in […]
Ack