Attention is currently required from: pespin, fixeria.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/31098 )
Change subject: rlcmac: Enqueue LLC PDUs based on RadioPriority and SAPI
......................................................................
Patch Set 3:
(2 comments)
File src/rlcmac/gre.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31098/comment/8ce5f9b8_b58fa759
PS3, Line 72: /* TODO: here a new UL TBF will be created if not available yet */
Yes, I'm adding code modules in a step-by-step
way, so that it's not a final code bomb with 30 files […]
Makes sense to do it
that way. Sometimes a TODO is kept unintentionally though, so that's why I keep asking
about them.
File src/rlcmac/llc_queue.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31098/comment/34b92ffd_7332e537
PS3, Line 196: /* rate_ctr_inc(CTR_LLC_FRAME_DROPPED); */
I left it there on purpose so that a potential counter
can be identified quickly and added there in […]
Ack
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/31098
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: Icdaa046fb6a71367f10beee16dcf9a5b7b61022e
Gerrit-Change-Number: 31098
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 30 Jan 2023 12:36:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment