Attention is currently required from: laforge, fixeria, pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31556 )
Change subject: library/RSL_Types: RSL_SpeechAlgo: support CSD ......................................................................
Patch Set 5:
(4 comments)
This change is ready for review.
File bts/BTS_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31556/comment/c46c21bc_382ca... PS4, Line 874: mode.u.speech
Be careful here. […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31556/comment/6aed041c_5ee3d... PS4, Line 2545: g_pars.chan_mode.u.sign == RSL_CMOD_NO_RESOURCE
`if (ischosen(g_pars.chan_mode.u.sign)) ... […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31556/comment/583bdb7e_8833f... PS4, Line 2547: else
`else if (ischosen(g_pars.chan_mode.u.speech)) ... […]
Done
File bts/BTS_Tests_VAMOS.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31556/comment/9878a4d7_7337c... PS4, Line 177: chan_mode.u.speech
same here, check `ischosen()` before accessing or match with a template
Done