Attention is currently required from: laforge, fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31556 ) Change subject: library/RSL_Types: RSL_SpeechAlgo: support CSD ...................................................................... Patch Set 5: (4 comments) This change is ready for review. File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31556/comment/c46c21bc_382ca... PS4, Line 874: mode.u.speech

Be careful here. […] Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31556/comment/6aed041c_5ee3d... PS4, Line 2545: g_pars.chan_mode.u.sign == RSL_CMOD_NO_RESOURCE

`if (ischosen(g_pars.chan_mode.u.sign)) ... […] Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31556/comment/583bdb7e_8833f... PS4, Line 2547: else

`else if (ischosen(g_pars.chan_mode.u.speech)) ... […] Done

File bts/BTS_Tests_VAMOS.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31556/comment/9878a4d7_7337c... PS4, Line 177: chan_mode.u.speech

same here, check `ischosen()` before accessing or match with a template Done

-- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31556 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ief2d95c7e9d71afb26fa74da755294226c8e158d Gerrit-Change-Number: 31556 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 02 Mar 2023 12:12:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment