Attention is currently required from: daniel.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33221 )
Change subject: stream: Update log messages ......................................................................
Patch Set 2:
(3 comments)
File src/stream.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/33221/comment/d564d226_5d0bf948 PS2, Line 564: LOGSCLI(cli, LOGL_DEBUG, "connection done.\n"); while at it, please remove the final dots. I just submitted a patch doing the same (I didn't see yours): https://gerrit.osmocom.org/c/libosmo-netif/+/33224 I'm happy to drop mine if you include it into yours.
https://gerrit.osmocom.org/c/libosmo-netif/+/33221/comment/bf28c770_3b550f39 PS2, Line 1605: LOGP(DLINP, LOGL_NOTICE, "Connection is being flushed and closed; ignoring received message\n"); INFO. NOTICE is too much, you are printing this every time you receive a message.
https://gerrit.osmocom.org/c/libosmo-netif/+/33221/comment/01a1a4f7_28e5828e PS2, Line 1710: if (conn == NULL) or simply OSMO_ASSERT(conn)