Attention is currently required from: daniel.

View Change

3 comments:

• File src/stream.c:

  • Patch Set #2, Line 564: LOGSCLI(cli, LOGL_DEBUG, "connection done.\n");

    while at it, please remove the final dots. I just submitted a patch doing the same (I didn't see yours): https://gerrit.osmocom.org/c/libosmo-netif/+/33224
    I'm happy to drop mine if you include it into yours.

  • Patch Set #2, Line 1605: LOGP(DLINP, LOGL_NOTICE, "Connection is being flushed and closed; ignoring received message\n");

    INFO. NOTICE is too much, you are printing this every time you receive a message.

  • Patch Set #2, Line 1710: if (conn == NULL)

    or simply OSMO_ASSERT(conn)

To view, visit change 33221. To unsubscribe, or for help writing mail filters, visit settings.