Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32552 )
Change subject: osmo-bts-trx: fix trx_ctrl_read_cb(): do not send CMDs twice ......................................................................
Patch Set 1:
(3 comments)
File src/osmo-bts-trx/trx_if.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/5bd48b0c_b89aa276 PS1, Line 732: /* Calling trx_ctrl_rx_rsp() may trigger code patch(s) queueing more CMDs. typo: path
https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/1527d654_29fda4ef PS1, Line 736: more_cmds = !llist_empty(&l1h->trx_ctrl_list); It would be much more clearing storing this in a var called list_was_empty = llist_empty()
https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/108f804f_be0fa48b PS1, Line 751: if (more_cmds) shouldn't this patch actually simply be here: ``` if (!llist_empty(&l1h->trx_ctrl_list)) trx_ctrl_send(l1h); ```