Attention is currently required from: fixeria.
3 comments:
File src/osmo-bts-trx/trx_if.c:
Patch Set #1, Line 732: /* Calling trx_ctrl_rx_rsp() may trigger code patch(s) queueing more CMDs.
typo: path
Patch Set #1, Line 736: more_cmds = !llist_empty(&l1h->trx_ctrl_list);
It would be much more clearing storing this in a var called list_was_empty = llist_empty()
Patch Set #1, Line 751: if (more_cmds)
shouldn't this patch actually simply be here:
```
if (!llist_empty(&l1h->trx_ctrl_list))
trx_ctrl_send(l1h);
```
To view, visit change 32552. To unsubscribe, or for help writing mail filters, visit settings.