Attention is currently required from: Hoernchen, fixeria, laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-uecups/+/40787?usp=email )
Change subject: tun_device: Make sure struct iphdr access is 4-byte aligned ......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
What about __attribute__((aligned(4))) or aligned alloca? This looks as brittle as the first version […]
Because I don't want to align the start of the buffer variable, but make sure an intermediate point in the buffer is aligned.
File daemon/tun_device.c:
https://gerrit.osmocom.org/c/osmo-uecups/+/40787/comment/999416a8_ffe92148?u... : PS2, Line 208: uint8_t base_buffer[payload_off_4byte_aligned + MAX_UDP_PACKET];
I would expect there are nice compiler pragmas/macros that allow for such alignment? I know the Linu […]
It's not about the initial buffer address, which I expect to be aligned, but the middle pointer where the iphdr gets stored.