Attention is currently required from: pespin, fixeria. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30616 )
Change subject: ipa: Add ipa_client_conn_open2 with connect timeout argument ......................................................................
Patch Set 3:
(5 comments)
File TODO-RELEASE:
https://gerrit.osmocom.org/c/libosmo-abis/+/30616/comment/28f125ce_22d8f945 PS2, Line 10: libosmo-abis API change New function ipa_client_conn_open2
better s/API change/new API/g, it helps me quickly understanding how to bump the libversion stuff.
Ack
File include/osmocom/abis/ipa.h:
https://gerrit.osmocom.org/c/libosmo-abis/+/30616/comment/7f45fd8d_3f2cb563 PS2, Line 108: int ipa_client_conn_open2(struct ipa_client_conn *link, int timeout);
connect_timeout?
Ack
File src/input/ipa.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/30616/comment/22fbfecf_8efba762 PS2, Line 41: osmo_timer_del(&link->timer); Here
https://gerrit.osmocom.org/c/libosmo-abis/+/30616/comment/7d366c24_8c16f5c1 PS2, Line 136: osmo_timer_del(&link->timer);
you should delete the timer before returning above, otherwise you leave it set if the socket returne […]
That's also called in ipa_conn_client_close() which is called from ipa_connect_failure()
This here is just the happy path deleting the timer on successful connect. Do you want me to add comments somewhere?
https://gerrit.osmocom.org/c/libosmo-abis/+/30616/comment/631aae25_7dce5149 PS2, Line 246: int ipa_client_conn_open2(struct ipa_client_conn *link, int timeout)
connect_tmeout
Ack