Attention is currently required from: pespin, fixeria.

View Change

5 comments:

• File TODO-RELEASE:

  • Patch Set #2, Line 10: libosmo-abis API change New function ipa_client_conn_open2

    better s/API change/new API/g, it helps me quickly understanding how to bump the libversion stuff.

    Ack

• File include/osmocom/abis/ipa.h:

  • Patch Set #2, Line 108: int ipa_client_conn_open2(struct ipa_client_conn *link, int timeout);

    connect_timeout?

    Ack

• File src/input/ipa.c:

  • Patch Set #2, Line 41: osmo_timer_del(&link->timer);

    Here

  • Patch Set #2, Line 136: osmo_timer_del(&link->timer);

    you should delete the timer before returning above, otherwise you leave it set if the socket returne […]

    That's also called in ipa_conn_client_close() which is called from ipa_connect_failure()

    This here is just the happy path deleting the timer on successful connect. Do you want me to add comments somewhere?

  • Patch Set #2, Line 246: int ipa_client_conn_open2(struct ipa_client_conn *link, int timeout)

    connect_tmeout

    Ack

To view, visit change 30616. To unsubscribe, or for help writing mail filters, visit settings.