Attention is currently required from: fixeria, jolly, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36317?usp=email )
Change subject: osmo-bts-virtual: Port over to osmo_io
......................................................................
Patch Set 2:
(2 comments)
File src/osmo-bts-virtual/osmo_mcast_sock.c:
https://gerrit.osmocom.org/c/osmo-bts/+/36317/comment/1b49f7ef_a0b09a10
PS2, Line 116: bidir_sock->read_cb = read_cb;
I wonder whether we still really need to store this field here.
mcsat_sock_read_cb (the iofd call-back) will dereference this pointer to call the user-provided callback function. Hence we need it.
File src/osmo-bts-virtual/scheduler_virtbts.c:
https://gerrit.osmocom.org/c/osmo-bts/+/36317/comment/6b9f9504_86aa0c76
PS2, Line 105: else if (rc == 0)
Ok, I commented the wrong file.
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/36317?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Icfe42da00fd446c38090055e2baa5d5e0ae5b70c
Gerrit-Change-Number: 36317
Gerrit-PatchSet: 2
Gerrit-Owner: laforge
laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: jolly
andreas@eversberg.eu
Gerrit-Attention: jolly
andreas@eversberg.eu
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Tue, 19 Mar 2024 13:03:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly
andreas@eversberg.eu
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Gerrit-MessageType: comment