Attention is currently required from: fixeria, jolly, pespin.

View Change

2 comments:

• File src/osmo-bts-virtual/osmo_mcast_sock.c:

  • Patch Set #2, Line 116: bidir_sock->read_cb = read_cb;

    I wonder whether we still really need to store this field here.

    mcsat_sock_read_cb (the iofd call-back) will dereference this pointer to call the user-provided callback function. Hence we need it.

• File src/osmo-bts-virtual/scheduler_virtbts.c:

  • Patch Set #2, Line 105: else if (rc == 0)

    Ok, I commented the wrong file.

    Done

To view, visit change 36317. To unsubscribe, or for help writing mail filters, visit settings.