Attention is currently required from: lynxis lazus.
Jenkins Builder has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email )
Change subject: vlr: add PS support
......................................................................
Patch Set 4:
(3 comments)
File src/libvlr/vlr_lu_fsm.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20732):
https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/4787f92c_702f1fe5?usp… :
PS4, Line 575: static int lu_compl_vlr_timeout(struct osmo_fsm_inst *fi) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20732):
https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/fa464eb1_263dbfc1?usp… :
PS4, Line 588: LOGPFSML(fi, LOGL_ERROR, "LU Compl timeout %i / %i \n",
fi->T, lcvp->N);
unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20732):
https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/88371f75_ff377a59?usp… :
PS4, Line 588: LOGPFSML(fi, LOGL_ERROR, "LU Compl timeout %i / %i \n",
fi->T, lcvp->N);
Use %d instead of %i
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0
Gerrit-Change-Number: 38490
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 06 Jan 2025 18:44:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No