Attention is currently required from: lynxis lazus.

View Change

3 comments:

• File src/libvlr/vlr_lu_fsm.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20732):

    Patch Set #4, Line 575: static int lu_compl_vlr_timeout(struct osmo_fsm_inst *fi) {

    open brace '{' following function definitions go on the next line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20732):

    Patch Set #4, Line 588: LOGPFSML(fi, LOGL_ERROR, "LU Compl timeout %i / %i \n", fi->T, lcvp->N);

    unnecessary whitespace before a quoted newline

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20732):

    Patch Set #4, Line 588: LOGPFSML(fi, LOGL_ERROR, "LU Compl timeout %i / %i \n", fi->T, lcvp->N);

    Use %d instead of %i

To view, visit change 38490. To unsubscribe, or for help writing mail filters, visit settings.