Attention is currently required from: dexter, fixeria, pespin.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34444?usp=email )
Change subject: write_queue: Enable updating max_length field ......................................................................
Patch Set 5:
(2 comments)
File src/core/write_queue.c:
https://gerrit.osmocom.org/c/libosmocore/+/34444/comment/fa459290_e53c7636 PS4, Line 153: * \returns Number of messages dropped.
I'd return an int, so we can add error codes later on. […]
I would prefer to leave it like this, if that's alright. I don't really see how we would add error codes in the future if none of the functions involved are written to return any errors.
https://gerrit.osmocom.org/c/libosmocore/+/34444/comment/6a075dc4_a2668f0b PS4, Line 157: size_t osmo_wqueue_update_maxlen(struct osmo_wqueue *queue, size_t len)
Let's call this "osmo_wqueue_set_maxlen()". […]
Done