Attention is currently required from: dexter, fixeria, pespin.

View Change

2 comments:

• File src/core/write_queue.c:

  • Patch Set #4, Line 153: * \returns Number of messages dropped.

    I'd return an int, so we can add error codes later on. […]

    I would prefer to leave it like this, if that's alright. I don't really see how we would add error codes in the future if none of the functions involved are written to return any errors.

  • Patch Set #4, Line 157: size_t osmo_wqueue_update_maxlen(struct osmo_wqueue *queue, size_t len)

    Let's call this "osmo_wqueue_set_maxlen()". […]

    Done

To view, visit change 34444. To unsubscribe, or for help writing mail filters, visit settings.