Attention is currently required from: laforge, dexter.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33690 )
Change subject: pySim/cards: Split legacy classes away from core SIM + UICC ......................................................................
Patch Set 4: Code-Review-1
(3 comments)
File pySim/cards.py:
https://gerrit.osmocom.org/c/pysim/+/33690/comment/daa21400_e2006d2a PS4, Line 31: base class Do we want to make it an abstract base class (`@abc.ABC`)?
https://gerrit.osmocom.org/c/pysim/+/33690/comment/f2757feb_e0555905 PS4, Line 41: self._aids = [] unreachable code
https://gerrit.osmocom.org/c/pysim/+/33690/comment/9b50a616_fc80f1be PS4, Line 319: SimCard `UiccCardBase` is a [grand]child of `SimCard`, do we really need `SimCard` here?