Attention is currently required from: fixeria, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666?usp=email )
Change subject: GSUP Templates: fix empty destination_name in GSUP ISD/UL ......................................................................
Patch Set 3:
(4 comments)
File library/GSUP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666/comment/4028ef49_99cb9... : PS2, Line 421: omit
This change makes no sense to me, since `ts_GSUP_UL_RES` cannot yield `omit`. It's always a value.
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666/comment/4d996413_94ddf... : PS2, Line 437: omit
This change makes no sense to me, since `ts_GSUP_UL_RES` cannot yield `omit`. It's always a value.
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666/comment/88f2c3a1_02dc3... : PS2, Line 447: omit
likewise, it should be `(value)`
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666/comment/0678b5db_9c9b7... : PS2, Line 448: template (omit) octetstring source_name := omit, :
please fix alignment here
hopefully this is correct.