Attention is currently required from: fixeria, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666?usp=email ) Change subject: GSUP Templates: fix empty destination_name in GSUP ISD/UL ...................................................................... Patch Set 3: (4 comments) File library/GSUP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666/comment/4028ef49_99cb9... : PS2, Line 421: omit
This change makes no sense to me, since `ts_GSUP_UL_RES` cannot yield `omit`. It's always a value. Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666/comment/4d996413_94ddf... : PS2, Line 437: omit
This change makes no sense to me, since `ts_GSUP_UL_RES` cannot yield `omit`. It's always a value. Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666/comment/88f2c3a1_02dc3... : PS2, Line 447: omit
likewise, it should be `(value)` Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666/comment/0678b5db_9c9b7... : PS2, Line 448: template (omit) octetstring source_name := omit, :
please fix alignment here hopefully this is correct.
-- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia89b5a82665e407fa578e5209fbcde0676326df0 Gerrit-Change-Number: 40666 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Thu, 21 Aug 2025 20:37:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>