Attention is currently required from: lynxis lazus.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39294?usp=email )
Change subject: Assign MME GroupId/Code to remote MMEs ......................................................................
Patch Set 3:
(1 comment)
File src/sgsn/gtp_mme.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/39294/comment/0b22db0a_3999d25c?usp... : PS3, Line 138: osmo_gummei_cmp Shouldn't you check `gummei_valid` before invoking `osmo_gummei_cmp()`? Otherwise you're comparing the given GUMMEI against a garbage or zero-initialized field? Even worse, this function will still yield a result even though the operator did `no gummei` via the VTY...