Attention is currently required from: lynxis lazus.
View Change
1 comment:
File src/sgsn/gtp_mme.c:
Patch Set #3, Line 138: osmo_gummei_cmp
Shouldn't you check `gummei_valid` before invoking `osmo_gummei_cmp()`? Otherwise you're comparing the given GUMMEI against a garbage or zero-initialized field? Even worse, this function will still yield a result even though the operator did `no gummei` via the VTY...
To view, visit change 39294. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I881aeba904fb6ca815842d36e466a2459ad81913
Gerrit-Change-Number: 39294
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis@fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis@fe80.eu>
Gerrit-Comment-Date: Mon, 17 Feb 2025 20:27:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No