Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34511?usp=email )
Change subject: sccplite: Support multiple MGW in MGW pool ......................................................................
Patch Set 1:
(7 comments)
Patchset:
PS1: cosmetics and a log level, otherwise LGTM
File src/osmo-bsc/osmo_bsc_mgcp.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/34511/comment/082e857d_1f79e967 PS1, Line 59: filled buf size 0
https://gerrit.osmocom.org/c/osmo-bsc/+/34511/comment/333b024b_700de504 PS1, Line 66: if (!eol) cosmetic: new line after the variable definitions?
https://gerrit.osmocom.org/c/osmo-bsc/+/34511/comment/46029111_373ba5b7 PS1, Line 121: with
https://gerrit.osmocom.org/c/osmo-bsc/+/34511/comment/23fc7974_70958db0 PS1, Line 123: Sine Since
https://gerrit.osmocom.org/c/osmo-bsc/+/34511/comment/fc2cf5ec_adc713bc PS1, Line 132: LOGL_NOTICE maybe LOGL_DEBUG? otherwise, if there are multiple mgws in the pool, this will appear quite a lot as I understand
https://gerrit.osmocom.org/c/osmo-bsc/+/34511/comment/6d3ac72b_ac801720 PS1, Line 170: indentation