Attention is currently required from: pespin.

View Change

7 comments:

• Patchset:

  • Patch Set #1:

    cosmetics and a log level, otherwise LGTM

• File src/osmo-bsc/osmo_bsc_mgcp.c:

  • Patch Set #1, Line 59: filled buf size

    0

  • Patch Set #1, Line 66: if (!eol)

    cosmetic: new line after the variable definitions?

  • Patch Set #1, Line 121:

    with

  • Patch Set #1, Line 123: Sine

    Since

  • Patch Set #1, Line 132: LOGL_NOTICE

    maybe LOGL_DEBUG? otherwise, if there are multiple mgws in the pool, this will appear quite a lot as I understand

  • Patch Set #1, Line 170:

    indentation

To view, visit change 34511. To unsubscribe, or for help writing mail filters, visit settings.