Attention is currently required from: Timur Davydov, neels, pespin.
fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email )
Change subject: Add Emscripten build support and JS callback logging backend ......................................................................
Patch Set 5:
(4 comments)
File src/core/osmo_io_internal.h:
https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/c04eea48_c9ec41d6?u... : PS5, Line 7: HAVE_LIBSCTP This comes from `config.h`, which is included below. I believe you need to move the include above, otherwise this ifdef is always false.
File src/vty/logging_vty.c:
https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/56a7df5e_043a9f62?u... : PS5, Line 1130: No need for a space here.
https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/8fc01b3e_525acbeb?u... : PS5, Line 1361: install_lib_element(CONFIG_NODE, &cfg_log_web_cmd); : install_lib_element(CONFIG_NODE, &cfg_no_log_web_cmd); I assume these commands are only relevant for emscripten?
```suggestion
#if defined(__EMSCRIPTEN__) install_lib_element(CONFIG_NODE, &cfg_log_web_cmd); install_lib_element(CONFIG_NODE, &cfg_no_log_web_cmd); #endif /* defined(__EMSCRIPTEN__) */ ```
File src/vty/telnet_interface_dummy.c:
https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/388cadc4_6123c7f8?u... : PS5, Line 18: #include <sys/socket.h> : #include <netinet/in.h> : #include <errno.h> : #include <stdlib.h> : #include <stdio.h> : #include <string.h> : #i (Not critical) Most if the includes are not needed here and can be removed?