Attention is currently required from: Timur Davydov, neels, pespin.

View Change

4 comments:

• File src/core/osmo_io_internal.h:

  • Patch Set #5, Line 7: HAVE_LIBSCTP

    This comes from `config.h`, which is included below.
    I believe you need to move the include above, otherwise this ifdef is always false.

• File src/vty/logging_vty.c:

  • Patch Set #5, Line 1130:

    No need for a space here.

  • Patch Set #5, Line 1361:

    install_lib_element(CONFIG_NODE, &cfg_log_web_cmd);
    	install_lib_element(CONFIG_NODE, &cfg_no_log_web_cmd);
    

    I assume these commands are only relevant for emscripten?

    
    ```suggestion

    #if defined(__EMSCRIPTEN__)
    	install_lib_element(CONFIG_NODE, &cfg_log_web_cmd);
    	install_lib_element(CONFIG_NODE, &cfg_no_log_web_cmd);
    #endif /* defined(__EMSCRIPTEN__) */
    ```

• File src/vty/telnet_interface_dummy.c:

  • Patch Set #5, Line 18:

    #include <sys/socket.h>
    #include <netinet/in.h>
    #include <errno.h>
    #include <stdlib.h>
    #include <stdio.h>
    #include <string.h>
    #i
    

    (Not critical) Most if the includes are not needed here and can be removed?

To view, visit change 41813. To unsubscribe, or for help writing mail filters, visit settings.