Attention is currently required from: arehbein, daniel.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/34224 )
Change subject: stream tests: Eliminate timestamps from output
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
First of all, I think we can agree that not knowing
the cause for these timestamps is unsatisfactory […]
1- I still didn't get to
look at this issue and test this patch myself, something I wanted to avoid doing so far
since it's the duty of whoever is submitting it to have it passing, or to ask me or
someone else for specific help with specific problems or if something is not clear
enough.
2- I think I may have not expressed with enough detail. Just in case, I'm doing it
again: I'm in favour to disable timestamp logging *of the osmocom IUT code*, aka the
app/library code tested, if it really makes no sense to test timing stuff (ideally it
should, with fake time enabled). On the other hand, disabling explicit timing logging
outputed by the test code itself should not be removed unless there's a good reason
for that (and "timestamps started changing but I don't know why" is not a
good reason). Those timestamps logs in the test code are basically showing and proving
that the code is working in a given way. If the code implementation changes and those need
to be updated, it should be explained *why* is that the case.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/34224
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I7faed932927d4f6e328a28c7f30a647a7272e89c
Gerrit-Change-Number: 34224
Gerrit-PatchSet: 2
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 01 Sep 2023 16:01:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment