Attention is currently required from: arehbein, daniel.
1 comment:
Patchset:
First of all, I think we can agree that not knowing the cause for these timestamps is unsatisfactory […]
1- I still didn't get to look at this issue and test this patch myself, something I wanted to avoid doing so far since it's the duty of whoever is submitting it to have it passing, or to ask me or someone else for specific help with specific problems or if something is not clear enough.
2- I think I may have not expressed with enough detail. Just in case, I'm doing it again: I'm in favour to disable timestamp logging *of the osmocom IUT code*, aka the app/library code tested, if it really makes no sense to test timing stuff (ideally it should, with fake time enabled). On the other hand, disabling explicit timing logging outputed by the test code itself should not be removed unless there's a good reason for that (and "timestamps started changing but I don't know why" is not a good reason). Those timestamps logs in the test code are basically showing and proving that the code is working in a given way. If the code implementation changes and those need to be updated, it should be explained *why* is that the case.
To view, visit change 34224. To unsubscribe, or for help writing mail filters, visit settings.