Attention is currently required from: jolly.
fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029?usp=email )
Change subject: Add unit tests for S1 HANDOVER procedure ......................................................................
Patch Set 1:
(5 comments)
File test/s1ap_proxy_test.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/f463dd18_24e9b... : PS1, Line 380: unrelated ws removal
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/a4c1c2cc_e1573... : PS1, Line 76: peperation prep{E->A}ration
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/968a0c48_30458... : PS1, Line 403: [?_assertMatch({forward, _}, s1ap_proxy:process_pdu(Pid, HandoverRqd)), : Here we expect the PDUs to be forwarded as-is (unmodified), right? We should not be matching anything here (`_`), but the same binary blobs:
``` ?_assertEqual({forward, HandoverRqd}, ... ?_assertEqual({forward, HandoverCmd}, ... ```
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/de23fb6d_38823... : PS1, Line 413: HANDOVER REQUEST This PDU actually goes from the MME to the target eNB, so `[eNB <- MME]`.
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/d135e0aa_28256... : PS1, Line 416: MME -> eNB ... and the opposite direction here: `[eNB -> MME]`.