Attention is currently required from: neels.
laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40096?usp=email )
Change subject: personalization: add param_source.py, implement batch personalization ......................................................................
Patch Set 3:
(3 comments)
File pySim/esim/saip/param_source.py:
https://gerrit.osmocom.org/c/pysim/+/40096/comment/53b4167f_f48d274a?usp=ema... : PS3, Line 33: abstract if it's abstract, should it be an abc.ABC ?
https://gerrit.osmocom.org/c/pysim/+/40096/comment/9aa7501a_9cbcced8?usp=ema... : PS3, Line 132: RandomDigitSource IMHO it's a bit unintuitive that the IncDigit inherits from RandomDigit. Maybe add a DigitSource from which both IncDigit + RandomDigit inherits?
https://gerrit.osmocom.org/c/pysim/+/40096/comment/ddc198b0_c5058a11?usp=ema... : PS3, Line 133: 'incrementing sequence of digits' cosmetic: the docstring here uses single-quotes, below for the method it uses double-quotes. This looks a bit inconsistent. In the existing code base, I think we always use multi-line """ style comments for this, irrespective if the actual comment is just a single line. That makes it easier to expand it later on without having to change quoting style.